-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: [M3-7195] - Marketplace OCA loading pattern POC #9724
Conversation
@@ -11,7 +11,7 @@ export const queryKey = 'stackscripts'; | |||
|
|||
export const useStackScriptsOCA = (enabled: boolean, params: Params = {}) => { | |||
return useQuery<StackScript[], APIError[]>( | |||
[`${queryKey}-oca-all`, params], | |||
`${queryKey}-oca-all`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix for the prefetching request being invalidated. on page visit. CC @bnussman
maxWidth: 'none', | ||
}, | ||
flexGrow: 10, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored the markup a little bit and no need for styled components for a couple css rules.
Closing for now - may reuse some of this to combine with #9732 |
Description 📝
As a follow up to #9704, I noticed a few issues and room for improving the visual loading pattern (long query, prefetching issue, multiple circular loaders).
Apart from the prefetching issue, this PR offers improvements as a proof of concept to visually help the user while the page is loading. Those changes will be submitted to UX as well for approval.
Major Changes 🔄
Preview 📷
How to test 🧪
Requisites: pull code locally
Refetching fix
Compare this behaviours with production and confirm fix + no regression
Visual fixes